feat: add authorship arguments to say_stream#1502
Open
zimeg wants to merge 3 commits into
Open
Conversation
The SDK now includes icon_emoji, icon_url, and username in ChatStream._stream_args. Update assertions to expect these keys. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Add icon_emoji, icon_url, and username parameters to say_stream() call, matching the new authorship support in slack_sdk v3.42.0. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
=======================================
Coverage 91.30% 91.30%
=======================================
Files 228 228
Lines 7271 7271
=======================================
Hits 6639 6639
Misses 632 632 ☔ View full report in Codecov by Sentry. |
Add icon_emoji, icon_url, and username parameters to set_status(), matching the new authorship support in slack_sdk v3.42.0. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Member
Author
|
⚡ Similar changes might not be needed in Bolt JS with the subtracted arguments: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
icon_emoji,icon_url, andusernameauthorship arguments toSayStream,AsyncSayStream,SetStatus, andAsyncSetStatushelpers to match the new authorship support added inslack_sdkv3.42.0 🚀Testing
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsRequirements
./scripts/install_all_and_run_tests.shafter making the changes.