Skip to content

fix(workflow-search): unclip block-name highlight shadow on the left#4670

Merged
waleedlatif1 merged 1 commit into
stagingfrom
waleedlatif1/fix-block-name-highlight-radius
May 19, 2026
Merged

fix(workflow-search): unclip block-name highlight shadow on the left#4670
waleedlatif1 merged 1 commit into
stagingfrom
waleedlatif1/fix-block-name-highlight-radius

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

@waleedlatif1 waleedlatif1 commented May 19, 2026

Summary

  • The editor title `

    ` uses `truncate` (overflow:hidden) with no left padding, so the workflow-search highlight's `-3px` box-shadow was getting clipped, exposing the mark's sharp left edge.

  • Adds 3px left padding to both the title `

    ` and the rename `` so the shadow renders symmetrically (matching the subblock-label highlight) and the title doesn't shift when toggling rename.

Before / After: the left edge of the orange highlight on the block name now has the same rounded corner as the right edge, and matches the appearance of the highlight on subblock labels like "Messages".

Test plan

  • Open a workflow with a block (e.g. "Agent 1"), open the in-workflow search, search a substring of the block name.
  • Navigate to the block-name match — the orange highlight on the title should have rounded corners on both sides.
  • Double-click the title to enter rename mode — the input text should not shift horizontally compared to the displayed h2.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 19, 2026 11:28pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Low Risk
Low risk styling-only change that adjusts padding on the editor title and rename input; minimal chance of UI alignment regressions confined to the header.

Overview
Fixes workflow-search highlighting in the editor header by adding pl-[3px] to both the title <h2> and rename <input>, preventing the left-side box-shadow on the <mark> highlight from being clipped and keeping text position consistent between view and rename modes.

Reviewed by Cursor Bugbot for commit a3d1ad7. Configure here.

@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/fix-block-name-highlight-radius branch from a3d1ad7 to ee691ea Compare May 19, 2026 23:20
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Greptile Summary

This PR fixes a cosmetic clipping bug where the left edge of the workflow-search orange highlight on block names appeared sharp (missing the rounded corner) because overflow: hidden from Tailwind's truncate utility was cutting off the -3px box-shadow on the <mark> element. Adding pl-[3px] to both the display <h2> and the rename <input> gives the shadow room to render, and keeping them in sync prevents a horizontal text shift when toggling rename mode.

  • Adds pl-[3px] to the block-title <h2> so the <mark> highlight's left box-shadow is no longer clipped by overflow: hidden.
  • Applies the same pl-[3px] to the rename <input> so text position is visually identical in both display and edit states.

Confidence Score: 5/5

Safe to merge — the change is two identical one-line CSS additions that fix a visual clipping artefact with no behavioural side effects.

Both the display <h2> and rename <input> receive the same 3 px left padding, so the fix is symmetric and cannot introduce a text-shift regression. The change touches no logic, state, or event handling.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx Adds pl-[3px] to both the rename <input> and display <h2> so the workflow-search highlight's -3px box-shadow is not clipped by overflow:hidden from truncate; padding is symmetric across both states to prevent text shift on toggle.

Reviews (1): Last reviewed commit: "fix(workflow-search): unclip block-name ..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/fix-block-name-highlight-radius branch from ee691ea to f58c9e1 Compare May 19, 2026 23:27
The editor title h2 uses truncate (overflow:hidden) so the search highlight's -3px box-shadow was getting clipped on the left, exposing the mark's sharp edge. Replaces overflow:hidden with overflow:clip plus a 3px overflow-clip-margin so the shadow can bleed past the clip boundary without shifting the title text or breaking truncation.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/fix-block-name-highlight-radius branch from f58c9e1 to c76be68 Compare May 19, 2026 23:28
@waleedlatif1 waleedlatif1 merged commit e40c915 into staging May 19, 2026
9 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/fix-block-name-highlight-radius branch May 19, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant