Skip to content

fix(branding): align auth and deploy UI colors#4669

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/color
May 19, 2026
Merged

fix(branding): align auth and deploy UI colors#4669
waleedlatif1 merged 1 commit into
stagingfrom
codex/color

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • align auth verification links, brand defaults, email styles, and app metadata with current brand colors
  • fix deploy modal URL field styling and chat allowed email persistence
  • clean up deploy modal code paths and remove dead form/template deploy modal code

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run check:api-validation:strict
  • bun run type-check
  • NEXT_PUBLIC_APP_URL=http://localhost:3000 bun run test hooks/queries/deployments.test.ts app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/hooks/deploy-action-lock.test.ts app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/hooks/use-deploy-readiness.test.ts app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/hooks/sync-local-draft.test.ts app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/chat/utils.test.ts

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 19, 2026 11:06pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Medium Risk
Medium risk due to broad UI token/variable renames (e.g. --brand-link--brand-accent) and deploy-modal behavior changes, though changes are mostly styling and dead-code removal.

Overview
Branding/token alignment: Updates default brand palette (now green/blue), propagates it through globals.css, PWA/SEO metadata (manifest.ts, whitelabeling/metadata.ts), and email styles, and renames whitelabel CSS vars from --brand-link* to --brand-accent* (plus new shared AUTH_TEXT_LINK for auth flows).

Deploy/auth UI fixes & cleanup: Normalizes error styling to --text-error, fixes deploy modal URL/input backgrounds, improves error handling in chat deploy (getErrorMessage) and allowed-email tag state so invalid entries don’t pollute persisted emails, and removes dead deploy-modal tabs/components for form/template deployment while simplifying several callbacks/memos.

Reviewed by Cursor Bugbot for commit 9aa2531. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Greptile Summary

This PR migrates the app's brand color palette from purple (#6f3dfa/#701ffc) to green (#33c482), aligning auth pages, emails, the deploy modal, and whitelabeling surfaces with the current brand. It also cleans up dead deploy-modal code paths (form and template deploy modes), renames CSS variables from --brand-link/--brand-link-hover to --brand-accent/--brand-accent-hover, and fixes a chat allowed-email persistence bug.

  • Brand color update: All hardcoded hex colors, CSS custom properties, manifest/metadata theme colors, and email styles updated to green. --gradient-primary/--gradient-secondary and --shadow-brand-inset tokens removed with corresponding Tailwind config cleanup.
  • CSS variable rename: --brand-link--brand-accent, --brand-link-hover--brand-accent-hover propagated through inject-theme.ts, org-branding-utils.ts, and a new AUTH_TEXT_LINK shared constant.
  • Dead code removal: form.tsx, template.tsx, embed-code-generator.tsx, form-builder.tsx, and use-identifier-validation.ts deleted; TabView type and deploy-modal imports cleaned up accordingly.
  • Email persistence fix (AuthSelector): emailItems state (initialized once from prop) replaced with a computed array derived directly from the emails prop, ensuring valid emails always reflect server state.

Confidence Score: 5/5

Safe to merge — all brand token references have been migrated consistently across CSS, Tailwind config, email styles, and whitelabeling utilities with no dangling usages of removed variables.

The brand color migration touches many files but follows a clear pattern: CSS variable renaming is fully coordinated (verified no remaining references to --brand-link, --brand-link-hover, --gradient-primary, --gradient-secondary, or --shadow-brand-inset), dead code removal is complete, and the chat email-persistence fix correctly derives emailItems from the emails prop rather than local state. No logic regressions were found.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/_styles/globals.css Replaces purple brand tokens with green ones; removes unused --gradient-primary/secondary and --shadow-brand-inset variables. Existing references cleaned up.
apps/sim/app/(auth)/components/auth-button-classes.ts Adds AUTH_TEXT_LINK shared constant using --brand-accent/--brand-accent-hover, both of which are defined in globals.css.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/chat/chat.tsx Fixes email persistence bug by computing emailItems from prop rather than state; adds getErrorMessage for type-safe error handling; styling tokens updated.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/deploy-modal.tsx Removes form/template tab dead code, adds isDeployModalTab type guard, removes useCallback/useMemo wrappers. All functional paths intact.
apps/sim/ee/whitelabeling/inject-theme.ts Correctly renames injected CSS vars from --brand-link/--brand-link-hover to --brand-accent/--brand-accent-hover to match the new variable names.
apps/sim/ee/whitelabeling/org-branding-utils.ts Same CSS variable rename as inject-theme.ts, applied for per-org whitelabeling overrides.
apps/sim/lib/branding/defaults.ts Updates all four theme color defaults to match the new green brand palette.
apps/sim/components/emails/_styles/base.ts Updates default brandPrimary email color fallback from purple to green; no behavioral change for whitelabeled instances.

Reviews (2): Last reviewed commit: "fix(branding): align auth and deploy UI ..." | Re-trigger Greptile

Comment thread apps/sim/lib/branding/defaults.ts Outdated
Comment thread apps/sim/app/_styles/globals.css
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9aa2531. Configure here.

@waleedlatif1 waleedlatif1 merged commit 972ec5f into staging May 19, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the codex/color branch May 19, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant