Infra: Move "Source" and "Last modified" from <article> to <footer>#4977
Open
hugovk wants to merge 1 commit into
Open
Infra: Move "Source" and "Last modified" from <article> to <footer>#4977hugovk wants to merge 1 commit into
<article> to <footer>#4977hugovk wants to merge 1 commit into
Conversation
Documentation build overview
735 files changed ·
|
Member
Author
Hmmm... 🤣 |
Member
Author
|
And of course, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at PRs like #4973, the Read the Docs comment says something like:
And lists all the PEPs. This is because they contain a "Last modified" timestamp in the footer.
For the RTD build, we're not fetching the whole commit history, so it's setting the last modified time as a recent time rather than the real last modified time. This doesn't really matter for the previews, better to have faster builds.
Right now, the PEP html structure is like:
We could configure RTD to ignore the bit of HTML containing the timestamp, but RTD already ignores changes in a
<footer>, and these things also semantically belong in a<footer>, which should also improve navigation for screen readers and so on.Therefore this PR moves "Source" and "Last modified" to a
<footer>:Also show the timestamp as "UTC" not "GMT": https://www.timeanddate.com/time/gmt-utc-time.html