Configurable build-details.json name#150098
Open
stefanor wants to merge 2 commits into
Open
Conversation
stefanor
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
Member
|
I would prefer to rename the configure option to something like What do you think? |
Contributor
Author
|
That works for me! |
stefanor
force-pushed
the
build-detials-name
branch
from
b6759d2 to
1345552
Compare
Linux distributions that co-install multiple Python versions in the same path (e.g. multiarch on Debian, debug builds, and free-threading) need a way to place multiple build-details.jsons side-by-side. PEP-739 is being updated [0] to recommend renaming in this situation. To ensure some standardization, this PR generates appropriate names for distributions that need to use this feature. [0]: python/peps#4889
stefanor
force-pushed
the
build-detials-name
branch
from
1345552 to
adb7586
Compare
Contributor
Author
|
@FFY00: Implemented that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux distributions that co-install multiple Python versions in the same path (e.g. multiarch on Debian, debug builds, and free-threading) need a way to place multiple
build-details.jsons side-by-side.PEP-739 is being updated to recommend renaming in this situation. To ensure some standardisation, this PR generates appropriate names for distributions that need to use this feature. The name will be exposed in
sysconfig.My first preference would be to always do this, using the
ABIFLAGSdirectly in the name. But this leads to less-human-readable names and the PEP authors preferred a static name where possible and a more verbose name, when we choose to rename.@FFY00