gh-150046: Pass -E to subprocesses from check_add_python_opts#150089
Open
pradyunsg wants to merge 2 commits into
Open
gh-150046: Pass -E to subprocesses from check_add_python_opts#150089pradyunsg wants to merge 2 commits into
-E to subprocesses from check_add_python_opts#150089pradyunsg wants to merge 2 commits into
Conversation
Avoid the runtime environment from affecting the tests' behaviours, which notably checks the warning filters which can be controlled by various environment variables.
pradyunsg
added
needs backport to 3.13
Member
There was a problem hiding this comment.
I don't think this needs a blurb, as noted in the devguide, test are excluded since they are of little interest to end users.
vstinner
reviewed
May 19, 2026
| proc = subprocess.run(cmd, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.STDOUT, | ||
| text=True) |
Member
There was a problem hiding this comment.
I would prefer passing env=support.make_clean_env() option rather than adding -E option, since the test checks that regrtest adds the -E option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the runtime environment from affecting the tests' behaviours, which checks the warning filters. The filters can be affected by various
PYTHON*environment variables.test_add_python_optsfails when executed withPYTHONDEVMODE=1in the environment #150046