gh-150077:Fix fileobj leak in tarfile.TarFile.zstopen on BaseException#150080
Open
lpyu001 wants to merge 2 commits into
Open
gh-150077:Fix fileobj leak in tarfile.TarFile.zstopen on BaseException#150080lpyu001 wants to merge 2 commits into
tarfile.TarFile.zstopen on BaseException#150080lpyu001 wants to merge 2 commits into
Conversation
lpyu001
changed the title
tarfile.TarFile.zstopen on BaseException
sobolevn
reviewed
May 19, 2026
| """ | ||
| def test_zstopen_closes_fileobj_on_base_exception(self): | ||
| fileobj = unittest.mock.Mock() | ||
| with unittest.mock.patch("compression.zstd.ZstdFile", |
Member
There was a problem hiding this comment.
I would suggest not to use a mock and check if a real file is closed or not.
| def test_zstopen_closes_fileobj_on_base_exception(self): | ||
| fileobj = unittest.mock.Mock() | ||
| with unittest.mock.patch("compression.zstd.ZstdFile", | ||
| return_value=fileobj), \ |
Member
There was a problem hiding this comment.
Suggested change
| return_value=fileobj), \ | |
| return_value=fileobj), |
You can use with ( instead of \
| Fix ``tarfile.TarFile.zstopen`` to close the underlying zstd file object | ||
| when opening the tar archive is interrupted by a :exc:`BaseException` | ||
| subclass such as :exc:`KeyboardInterrupt`. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue:#150077
zstopenusesexcept Exception:and leaksfileobjonBaseException, inconsistent withgzopen/bz2open/xzopen#150077