-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
gh-47169: Adding errno Symbolic Values to OSError.__str__()
#150041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
30707da
add : tests that shows bpo-2920 failure.
sadrasabouri 182986d
add : another failing case added.
sadrasabouri d628de1
update : exceptions updated.
sadrasabouri 09e381d
update : tests updated.
sadrasabouri 36c3512
move : error list moved to errnonames header.
sadrasabouri 8fe84d6
add : `OSError_format_errno` method added for finer printing.
sadrasabouri adc8ea7
update : other parts of the code updated.
sadrasabouri 2632257
add : blurb added.
sadrasabouri 08b39a4
fix : trimming whitespace removed.
sadrasabouri 79b305a
Merge branch 'main' into bpo-2920
ned-deily b21b313
fix : MAX_SIZE set for `errnonames.h`.
sadrasabouri 156cd0c
fix : comments regarding rst applied.
sadrasabouri 6d0ca87
fix : test_exceptions fixed.
sadrasabouri 044e421
fix : typo fixed.
sadrasabouri 3fd8007
Merge remote-tracking branch 'origin-sadra/bpo-2920' into bpo-2920
sadrasabouri fc217f8
Merge remote-tracking branch 'origin/main' into bpo-2920
sadrasabouri c8a4a31
fix : other tests static fixed.
sadrasabouri f207421
fix : system-based error fixed.
sadrasabouri 6cde14b
fix : limit size for `errnonames.h` increased.
sadrasabouri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2026-05-18-16-20-18.gh-issue-47169.kE86QZ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Include the symbolic error name in :exc:`OSError` exception string representations. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exists in the CPython codebase; that makes me worry this same sort of string matching may exist in many other codebases and will be broken by this change...
Is there some way we could measure/check for that? Keeping the symbolic name outside the
[]would limit breakage some.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. It's a valid concern indeed. I ran
rg -n '\[Errno [^]]*\]|OSError: \[Errno' Lib Tools Objects Modules Pythonand found cases treating the int after Error as a format.The two other alternatives are as follows, let me know which one looks better:
[Errno 2] (ENOENT) No such file or directory[Errno 2] No such file or directory (ENOENT)I like 1 bettter, to avoid confusion.