test: deflake async-hooks statwatcher test#63396
Open
trivikr wants to merge 1 commit into
Open
Conversation
Wait for the initial missing-file poll before writing watched files. Otherwise uv_fs_poll can observe the created file as its baseline and never emit the expected change event. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
async_hooks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63396 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 714 714
Lines 225704 225704
Branches 42714 42714
=======================================
+ Hits 203250 203269 +19
+ Misses 14225 14218 -7
+ Partials 8229 8217 -12 🚀 New features to boost your workflow:
|
aduh95
approved these changes
May 18, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
author ready
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
async-hooks/test-statwatcherto wait untilfs.watchFile()has observed the initial missing-file state before writing the watched files.
Without that ordering,
uv_fs_pollcan race with the test write and use thenewly created file as its initial baseline. In that case no later change is
emitted, so the test can hang until the harness timeout.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-15.md#jstest-failure
Assisted-by: openai:gpt-5.5