Skip to content

docs: describe manual PR image creation#2510

Open
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:manual-version-contributing
Open

docs: describe manual PR image creation#2510
MikeMcC399 wants to merge 1 commit into
nodejs:mainfrom
MikeMcC399:manual-version-contributing

Conversation

@MikeMcC399
Copy link
Copy Markdown
Contributor

Description

Instructions are added to the CONTRIBUTING document to clarify when it may be necessary to open a PR to create new images manually.

Motivation and Context

Originally the CONTRIBUTING document had no description of the automated process for image creation and it included a blanket invitation for users to submit update PRs.

The hierarchy of PR creation should be:

  1. automated creation
  2. manual creation by team member if automated creation fails
  3. manual creation by other user if all else fails

Testing Details

N/A

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 19, 2026 11:50
@MikeMcC399 MikeMcC399 requested a review from nschonni May 19, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: misleading CONTRIBUTING invitation to update versions

1 participant