Skip to content

TPT-4443: Fix flaky tests#698

Open
mawilk90 wants to merge 4 commits into
linode:devfrom
mawilk90:hotfix/flaky_tests_fixes
Open

TPT-4443: Fix flaky tests#698
mawilk90 wants to merge 4 commits into
linode:devfrom
mawilk90:hotfix/flaky_tests_fixes

Conversation

@mawilk90
Copy link
Copy Markdown
Contributor

@mawilk90 mawilk90 commented May 15, 2026

📝 Description

Failing regression fixes

✔️ How to Test

make test-int TEST_SUITE=linode_client TEST_ARGS="-k 'fails_to_create_domain or image_create or fails_to_create_image or fails_to_delete_predef or get_volume or create_tag or get_account'"
make test-int TEST_SUITE=domain
make test-int TEST_SUITE=placement
make test-int TEST_SUITE=linode TEST_CASE=test_linode_rebuild
make test-int TEST_SUITE=account TEST_CASE=test_latest_get_event

@mawilk90 mawilk90 force-pushed the hotfix/flaky_tests_fixes branch from 23089eb to 203479b Compare May 15, 2026 12:38
@mawilk90 mawilk90 changed the title Hotfix/flaky tests fixes TPT-4443: Fix flaky tests May 15, 2026
@mawilk90 mawilk90 added testing for updates to the testing suite in the changelog. hotfix for hotfixes that do not have a corresponding Jira ticket labels May 15, 2026
@mawilk90 mawilk90 force-pushed the hotfix/flaky_tests_fixes branch from d35ffe8 to abe5a53 Compare May 19, 2026 10:44
@mawilk90 mawilk90 requested a review from Copilot May 19, 2026 12:13
@mawilk90 mawilk90 marked this pull request as ready for review May 19, 2026 12:13
@mawilk90 mawilk90 requested review from a team as code owners May 19, 2026 12:13
@mawilk90 mawilk90 requested review from lgarber-akamai and psnoch-akamai and removed request for a team May 19, 2026 12:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several integration tests to reduce flakiness by increasing polling timeouts and adding/standardizing explicit waits around eventually-consistent API behaviors (e.g., resource readiness and tag visibility).

Changes:

  • Increased timeouts/intervals in multiple integration tests to better accommodate slower provisioning/migrations.
  • Replaced ad-hoc try/except assertions with pytest.raises for clearer, more consistent failure expectations.
  • Added targeted readiness polling (e.g., domain/volume “active”, Linode disks ready, tag creation visible) to reduce race conditions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/integration/models/placement/test_placement.py Increased migration request timeout to reduce flakiness.
test/integration/models/linode/test_linode.py Increased rebuild “running” wait timeout.
test/integration/models/domain/test_domain.py Increased post-clone sleep (but still uses fixed sleep).
test/integration/models/account/test_account.py Increased wait parameters before reading latest events.
test/integration/linode_client/test_linode_client.py Added wait_for_condition-based polling for disk/tag readiness; standardized error assertions with pytest.raises.
test/integration/conftest.py Added waits to ensure created domain/volume reach “active” before use.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/integration/models/domain/test_domain.py
Comment thread test/integration/models/account/test_account.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix for hotfixes that do not have a corresponding Jira ticket testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants