fix: hide internal rest param from prefixed middleware#235
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233.
Summary
{/*rest}wildcard used for prefixed router middleware from being copied intoctx.paramsValidation
npm run ts:checknpm run ts:check:testnpm run lintnpm run buildnpm run format:checkgit diff --check$env:TS_NODE_PROJECT='tsconfig.ts-node.json'; node --require ts-node/register --test --test-name-pattern "does not expose internal rest param" test/router.test.ts$env:TS_NODE_PROJECT='tsconfig.ts-node.json'; node --require ts-node/register --test --test-name-pattern "Router#prefix" test/router.test.ts$env:TS_NODE_PROJECT='tsconfig.ts-node.json'; node --require ts-node/register --test test/router.test.ts$env:TS_NODE_PROJECT='tsconfig.ts-node.json'; node --require ts-node/register --test test/layer.test.ts$env:TS_NODE_PROJECT='tsconfig.ts-node.json'; node --require ts-node/register --test test/utils/*.test.tsnpm run test:core/ the pre-committest:allcommand could not run directly on this Windows shell because the package scripts use POSIX-styleTS_NODE_PROJECT=...environment assignment. Running the equivalent PowerShell commands above passed for the touched test areas; the full command additionally hit existing Windows shelling failures intest/index.test.tsafternpm run build.