Release 3.4.0: SpilloverDiD (Butts 2021), Bacon R-parity goldens, agent-discoverability surface, PreTrendsPower R-parity audit#470
Merged
Conversation
…nt-discoverability surface, MPD+absorb HC2/HC2-BM auto-route, PreTrendsPower R-parity audit, Roth (2022) paper review, dCDH predict_het × placebo R-parity Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Overall Assessment ✅ Looks good This is a release-cut / metadata-only PR. I found no unmitigated P0 or P1 issues in the reviewed diff. Executive Summary
Methodology
Code Quality
Performance
Maintainability
Tech Debt
Security
Documentation/Tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor release. Bumps version 3.3.3 -> 3.4.0 across
pyproject.toml,rust/Cargo.toml,diff_diff/__init__.py,diff_diff/guides/llms-full.txt,CITATION.cff(withdate-released: 2026-05-19), and splits theCHANGELOG.md[Unreleased]section into a new empty[Unreleased]+[3.4.0] - 2026-05-19block with comparison link.Per the project SemVer convention (minor reserved for new estimator classes; additive extensions, new variance methods, new kwargs are patch-level), this is a minor bump because
[Unreleased]adds a new top-level estimator (SpilloverDiD).What landed since 3.3.3 (full detail in CHANGELOG
[3.4.0]):SpilloverDiD- ring-indicator spillover-aware DiD (Butts 2021). New standalone estimator atdiff_diff/spillover.py. Waves A-D: base estimator + Conley spatial-HAC SE + event-study (per-event-time x ring) decomposition + GMM df correction. Full docs surface (docs/api/spillover.rst, REGISTRY, references, methodology paper review).METHODOLOGY_REVIEW.mdrow. R-parity goldens atbenchmarks/data/r_bacondecomp_golden.json. Behavior change: defaultweightsflipped from"approximate"to"exact"per the methodology audit; pre-PR behavior reproducible viaweights="approximate".DifferenceInDifferences(absorb=..., vcov_type in {\"hc2\", \"hc2_bm\"})now supported via internal auto-route promotingabsorb=tofixed_effects=so the full hat-matrix-dependent HC2 leverage correction and CR2 Bell-McCaffrey DOF are computed correctly. R-parity vssandwich::vcovHCandclubSandwich::vcovCRat ~1e-10.MultiPeriodDiD(cluster=..., vcov_type=\"hc2_bm\")now supported via new_compute_cr2_bm_contrast_dofhelper generalizing the per-coefficient Pustejovsky-Tipton 2018 algebra to arbitrary(k, m)contrast matrices for the post-period-average ATT DOF; cluster-aware Satterthwaite DOF R-verified againstclubSandwich::Wald_test(test=\"HTZ\").pretrends.pyrewrite (+964 lines), 14+ CI rounds of methodology polish, R-parity golden generator atbenchmarks/R/generate_pretrends_golden.R, comprehensivetests/test_methodology_pretrends.py(1,164 lines).agent_workflow(df, unit=..., time=..., treatment=..., outcome=...)stateless orchestrator,dir(diff_diff)agent-facing-first ordering via_OrderedName(str)subclass, top-level__doc__rewritten to lead with the agent workflow recommendation, contract test attests/test_agent_discoverability.py.ChaisemartinDHaultfoeuille.predict_het x placeboR-parity on both global and per-path surfaces; t-distribution DF threading in_compute_heterogeneity_test(closes TODO pilot-412).generate_ddd_panel_data- new panel-structured DGP helper for Triple-Difference power analysis.docs/methodology/papers/roth-2022-review.md.Methodology references (required if estimator / math changes)
docs/methodology/REGISTRY.md(## SpilloverDiD,## BaconDecomposition,## PreTrendsPower,## DifferenceInDifferences,## MultiPeriodDiD,## ChaisemartinDHaultfoeuille).[3.4.0]bullets - each cites its papers inline.Validation
Security / privacy