fix(strawberry): Fix AttributeError on graphql_span in resolve#6289
Open
sentrivana wants to merge 3 commits into
Open
fix(strawberry): Fix AttributeError on graphql_span in resolve#6289sentrivana wants to merge 3 commits into
AttributeError on graphql_span in resolve#6289sentrivana wants to merge 3 commits into
Conversation
Strawberry's MiddlewareManager is cached on the schema, so resolve() runs on stale extension instances from the first request. Use sentry_sdk.start_span() instead of self.graphql_span.start_child() so resolve spans parent correctly via the scope rather than relying on instance state. Also prepend (rather than append) the Sentry extension so it wraps all other extensions as the outermost layer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 43.93s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 15082 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 33.53% 32.49% -1.04%
==========================================
Files 190 190 —
Lines 22342 22342 —
Branches 7576 7576 —
==========================================
+ Hits 7492 7260 -232
- Misses 14850 15082 +232
- Partials 749 695 -54Generated by Codecov Action |
sentrivana
changed the title
AttributeError on graphql_span in resolve
ericapisani
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strawberry's
MiddlewareManageris cached on the schema, soresolve()runs on stale extension instances from the first request. Usestart_span()instead ofself.graphql_span.start_child()so resolve spans parent correctly via the scope rather than relying on instance state.Also prepend (rather than append) the Sentry extension so it wraps all other extensions as the outermost layer and captures the whole request.
Also make all instance variables that are only used in one method local.
Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)