Skip to content

Display names for API endpoints are inconsistent w/ API reference#45721

Open
noahtalerman wants to merge 3 commits into
mainfrom
noahtalerman-patch-82
Open

Display names for API endpoints are inconsistent w/ API reference#45721
noahtalerman wants to merge 3 commits into
mainfrom
noahtalerman-patch-82

Conversation

@noahtalerman
Copy link
Copy Markdown
Member

@noahtalerman noahtalerman commented May 18, 2026

  • Add @rachaelshaw as reviewer to every PR against the API endpoints YAML
  • "fleet-level X" v. "a fleet's X"

Summary by CodeRabbit

  • Documentation
    • Updated API endpoint labels to use consistent "fleet-level" terminology across enroll secrets, policies, and agent options endpoints for improved clarity.

Review Change Stack

- Add @rachaelshaw as reviewer to every PR against the API endpoints YAML
- "fleet-level X" v. "a fleet's X" 
  - Up to @rachaelshaw
@noahtalerman noahtalerman marked this pull request as ready for review May 18, 2026 16:25
@noahtalerman noahtalerman requested review from a team and rachaelshaw as code owners May 18, 2026 16:25
@fleet-release fleet-release requested a review from eashaw May 18, 2026 16:25
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 41376a85-2546-4aa7-b14f-867e5f7f11b2

📥 Commits

Reviewing files that changed from the base of the PR and between b0d429e and 98b8335.

⛔ Files ignored due to path filters (1)
  • docs/REST API/rest-api.md is excluded by !**/*.md
📒 Files selected for processing (2)
  • server/api_endpoints/api_endpoints.yml
  • website/config/custom.js

Walkthrough

This PR standardizes API endpoint display names for fleet-scoped operations to use consistent "fleet-level" terminology. Display names were updated for enroll secrets endpoints, fleet policy operations (list, count, get individual policy, and delete), and fleet agent options. The software title icon deletion endpoint display name line was also touched. Additionally, the API endpoints file was assigned to DRI rachaelshaw in the custom configuration.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks required template sections (related issue, checklist items, testing details). It only provides informal notes about adding a reviewer and wording decisions. Add required sections from the template including related issue number, checklist items for user-visible changes and testing, and comprehensive details about what was changed and tested.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating API endpoint display names to use consistent 'fleet-level' wording across endpoints.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch noahtalerman-patch-82

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.75%. Comparing base (b0d429e) to head (98b8335).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #45721      +/-   ##
==========================================
- Coverage   66.75%   66.75%   -0.01%     
==========================================
  Files        2745     2745              
  Lines      219375   219375              
  Branches    10839    10839              
==========================================
- Hits       146435   146433       -2     
- Misses      59706    59707       +1     
- Partials    13234    13235       +1     
Flag Coverage Δ
backend 68.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants