Add cname-domain override and lowercase normalization to dhcp-to-dns#123
Draft
witul wants to merge 3 commits into
Draft
Add cname-domain override and lowercase normalization to dhcp-to-dns#123witul wants to merge 3 commits into
witul wants to merge 3 commits into
Conversation
Owner
|
Hmm, why is this marked as draft? Anyway, found this interesting and reworked it a bit. This is the current state, currently in
Feedback welcome... An thanks a lot for your contribution! |
Owner
|
Oh, just remembered... We can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements to dhcp-to-dns:
Allow a separate domain for CNAME records (A records keep their
MAC-based name in the technical domain, CNAMEs can resolve to a
cleaner one). Configurable at three levels:
Normalize generated DNS names to lowercase. DHCP clients often send
mixed-case hostnames (e.g. DESKTOP-ABC123, iPhone-XYZ). A new
ToLower helper in global-functions is used for both the MAC-based
A record name and the hostname CNAME.