Add comments explaining what entrypoint is supposed to do#7792
Conversation
|
How would this be reproduced? We create the code-server/ci/release-image/Dockerfile Lines 37 to 38 in 53d981a If the user is not code-server/ci/release-image/entrypoint.sh Lines 14 to 15 in 53d981a |
Okay, so now imagine the crazy hypothetical scenario where literally any part of that very specific scaffolding for this specific fork of the codebase provided by the outside environment changes, for any reason, like if, I dunno, the name of the company changed and you missed one or two extant references to it. |
|
Or rather, sorry, I guess I just don't understand how any of these variables are expected to work because there are zero usable comments here. The idea is that the line we're deleting isn't supposed to be deleting the user named by |
Also fixes the case where DOCKER_USER=coder
|
Here, I've updated the PR, here's a version where you can tell what cases would and wouldn't have bugs because the code actually describes what it's trying to do. |
This way the
DOCKER_USERvariable won't accidentally retain sudoer permissions for any user not namedcoder(almost certainly a security hole).