Skip integration tests on fork PRs#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests
git pushto the repo. Fork PRs only get a read-onlyGITHUB_TOKEN, so thetestjob always 403s. This PR skips thetestjob when the PR comes from a fork.If my understanding is correct, coverage is unchanged because
merge_groupstill runs the full suite before merge:The resulting flow for a fork contribution:
pull_requestfires. Code is untrusted,GITHUB_TOKENis read-only,CI / Testis skipped.merge_groupfires in the base repo context with a writableGITHUB_TOKEN, running the full suite against the now-trusted code.merge_grouppass, the commit lands onmain.CI / Testinmerge_groupfails, the required checkCI / CI OKwill also fail, and the commit won't land.