Skip to content

Add support to update secondary and primary storage URLs#13193

Draft
Pearl1594 wants to merge 1 commit into
mainfrom
support-update-pri-sec-stg-url
Draft

Add support to update secondary and primary storage URLs#13193
Pearl1594 wants to merge 1 commit into
mainfrom
support-update-pri-sec-stg-url

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR fixes: #11742

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented May 19, 2026

@DaanHoogland do you think we need to expose updating this via UI or leave this as a API only field? I feel it could be a bit of a dangerous operation should it be used incorrectly.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.08%. Comparing base (522283b) to head (3bae392).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 21 Missing ⚠️
...api/command/admin/storage/UpdateImageStoreCmd.java 0.00% 3 Missing ⚠️
...src/main/java/com/cloud/server/StatsCollector.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13193      +/-   ##
============================================
- Coverage     18.08%   18.08%   -0.01%     
- Complexity    16718    16719       +1     
============================================
  Files          6037     6037              
  Lines        542580   542665      +85     
  Branches      66427    66444      +17     
============================================
+ Hits          98136    98141       +5     
- Misses       433417   433497      +80     
  Partials      11027    11027              
Flag Coverage Δ
uitests 3.51% <ø> (ø)
unittests 19.24% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to change storage server IP addresses with the API and in the UI

1 participant