Fix a double-free bug#2112
Open
mdboom wants to merge 3 commits into
Open
Conversation
mdboom
added
bug
|
leofang
reviewed
May 20, 2026
Member
There was a problem hiding this comment.
Q: So the new tests would break without this fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of my experimentation with using an LLM agent for static analysis.
Fixes a double-free in the generated setters for list-valued struct members
(e.g.
CUlaunchConfig.attrs,CUDA_MEM_ALLOC_NODE_PARAMS.accessDescs,external-semaphore and batch-mem-op node parameter arrays, and their runtime
counterparts). Assigning an empty list freed the internal buffer but left
the cached pointer non-NULL, so a subsequent assignment or
__dealloc__would call
free()again on the dangling pointer.